[PATCH] Consider error-reporting calls cold in BPI

[Meador Inge]

Ping.  You all OK with the general direction of this cleanup?

On 01/17/2014 02:59 PM, Meador Inge wrote:
> Chandler, Hal,
> 
> On 11/16/2013 06:32 PM, Chandler Carruth wrote:
> 
>> On Fri, Nov 15, 2013 at 4:40 PM, Hal Finkel <hfinkel at anl.gov
>> <mailto:hfinkel at anl.gov>> wrote:
>>
>>     Chandler, are you okay with me committing this as is? As noted, I think that
>>     it matches the existing design.
>>
>>
>> I suppose. This is bad enough that someone needs to go clean up the entire file
>> immediately... but I guess I shouldn't hold up this patch on that front.
> 
> Many apologies for the delay.  I finally got around to taking a look at what we
> can do to clean this file up.  I am not looking for a full review now (I will
> send out a proper separate patch for that), but could y'all give it a quick
> look to see if the general approach is better?  If the general approach is
> OK, then I will do another pass to clean things up a bit more.
> 
> I believe I have simplified the design quite a bit and find the result much
> more straight forward.  All the little classes are gone and I was able to drop
> about 200 lines of code.
> 
> I am attaching the new file and diff since there is so much noise in the diff.
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 


-- 
Meador Inge
CodeSourcery / Mentor Embedded