[PATCH] [RFC] Compiler-RT on ARM via CMake

Renato Golin renato.golin at linaro.org
Fri Jan 24 02:14:00 PST 2014


On 24 January 2014 08:16, Alexey Samsonov <samsonov at google.com> wrote:

>   1) We might want to fix the Clang driver to correctly build the expected
> name of sanitizer runtime libraries on ARM.  See
> addSanitizerRTLinkFlagsLinux in clang/lib/Driver/Tools.cpp - maybe on ARM
> we should use something different than ToolChain::getArchName().
>

Or maybe we want to generate specific arch names, so that we deal with
soft/hard float and support issues, as Saleem mentioned. I'd say, to
simplify things, we could try getArchName() and if it failed, try "arm",
which should work with any ARMv4+ architecture (thus, soft-fp).

For now, setting it to "arm" and hoping everything else is setup correctly
would allow us to test things. A big FIXME should be added to Clang and RT
to make sure we don't forget.


  2) Your changes to lit.common.cfg shouldn't be necessary after r199979.
>

Right, I'll check.


  3) You should also add "arm" to filter_available_targets line in
> lib/ubsan/CMakeLists.txt to enable building UBSan.
>

I may have to add to all sanitizer's CMake files. Will do, thanks!

--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140124/200eb2b1/attachment.html>


More information about the llvm-commits mailing list