[PATCH] Adding diversity for security

[Nadav Rotem]

I think that the current patch is much better. One thing that you need to keep in mind is that the SelectionDAG scheduler is going away, so you probably want to focus your effort on the new scheduler. 

Thanks,
Nadav

On Jan 23, 2014, at 3:19 PM, Alp Toker <alp at nuanti.com> wrote:

> Hi Nadav,
> 
> Do you think this is satisfactory now? I don't have a clear idea of whether it's still intrusive in terms of the backend or if that's been addressed.
> 
> It does look like the patch has come a long way so in interest of unblocking the review queue I've offered to help Julian work on additional requirements like making the RNG non-global after the initial patches land in LLVM and clang if the feature seems desirable overall.
> 
> What do you think?
> 
> Alp.
> 
> 
> 
> On 23/01/2014 23:08, Julian Lettner wrote:
>>   Move patch forward to ToT.
>> 
>> Hi rinon, ahomescu,
>> 
>> http://llvm-reviews.chandlerc.com/D1802
>> 
>> CHANGE SINCE LAST DIFF
>>   http://llvm-reviews.chandlerc.com/D1802?vs=6581&id=6621#toc
>> 
>> Files:
>>   include/llvm/CodeGen/CommandFlags.h
>>   include/llvm/MC/MCRegisterInfo.h
>>   include/llvm/Support/RandomNumberGenerator.h
>>   include/llvm/Target/TargetOptions.h
>>   lib/CodeGen/LLVMBuild.txt
>>   lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp
>>   lib/LTO/LTOCodeGenerator.cpp
>>   lib/LTO/LTOModule.cpp
>>   lib/Support/CMakeLists.txt
>>   lib/Support/RandomNumberGenerator.cpp
>>   lib/Target/X86/CMakeLists.txt
>>   lib/Target/X86/NOPInsertion.cpp
>>   lib/Target/X86/X86.h
>>   lib/Target/X86/X86TargetMachine.cpp
>>   test/CodeGen/X86/nop-insert-percentage.ll
>>   test/CodeGen/X86/nop-insert.ll
>>   test/CodeGen/X86/sched-rnd-test.ll
>>   tools/llc/llc.cpp
>>   tools/llvm-lto/llvm-lto.cpp
>>   tools/lto/lto.cpp
>>   tools/opt/opt.cpp
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> -- 
> http://www.nuanti.com
> the browser experts
>