[PATCH] Customize a relocation table output format (rel / rela)

Rui Ueyama ruiu at google.com
Thu Jan 23 13:13:01 PST 2014


  LGTM with some nits.


================
Comment at: lib/ReaderWriter/ELF/SectionChunks.h:974
@@ +973,3 @@
+    uint32_t index = _symbolTable
+                         ? _symbolTable->getSymbolTableIndex(ref.target())
+                         : (uint32_t)STN_UNDEF;
----------------
Too much indentation.

================
Comment at: lib/ReaderWriter/ELF/SectionChunks.h:992
@@ +991,3 @@
+    uint32_t index = _symbolTable
+                         ? _symbolTable->getSymbolTableIndex(ref.target())
+                         : (uint32_t)STN_UNDEF;
----------------
Ditto


http://llvm-reviews.chandlerc.com/D2601



More information about the llvm-commits mailing list