[llvm] r199835 - Eliminate inappropriate use of FindProgramByName() from lli

[Chandler Carruth]

On Wed, Jan 22, 2014 at 10:07 PM, Alp Toker <alp at nuanti.com> wrote:

> Hi Nick,
>
> lli-child-target is more like a test input that happens to also be a
> byproduct of the build system. As such I've tested it the same way we test
> plugins using the corresponding %shlibext substitution.
>
> The fact it's built with add_llvm_tool() and links in the whole of LLVM
> appears is just another bug that needs fixing so I'd certainly avoid giving
> it a substitution the we do for actual installed tools like %clang or %lli.
> Does that make sense to you?
>

Personally, I find the design of just doing whole-file-name substitution
simpler to reason about than substituting file extensions. (I feel the same
way about %shlibext, but honestly hadn't noticed it.)

It's not a big deal either way, but all things being equal it seems more
consistent to just substitute the file name. :: shrug ::


(FWIW, I agree that the remote jit stuff doesn't feel finished or well
engineered. It could definitely use some love...)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140122/6553f7b9/attachment.html>