[PATCH] [AArch64 NEON] Try to generate CONCAT_VECTOR when lowering BUILD_VECTOR or SHUFFLE_VECTOR.

[Kevin Qin]

Hi James,

Thanks for point out those spelling mistakes. r199858 is committed to fix
them.


Regards,

Kevin


2014/1/22 James Molloy <james at jamesmolloy.co.uk>

> Hi Kevin,
>
> A minor nit with this patch: There are spelling mistakes in both the
> comments and the names of variables. Please could you quickly fix them so
> it is easier to maintain?
>
>  // Check whether a shuffle_vecotor could be presented as conact_vector.
>
> shuffle_vector, concat_vector.
>
> bool isContactVector = true;
>
> isConcatVector
>
>     if (isConactVector(Op, DAG, V1, V2, &ShuffleMask[0], Res))
> isConcatVector
>
>
> Cheers,
>
> James
>
>
> On 22 January 2014 03:47, Jiangning Liu <liujiangning1 at gmail.com> wrote:
>
>> LGTM!
>>
>> Thanks,
>> -Jiangning
>>
>>
>> 2014/1/15 Kevin Qin <kevinqindev at gmail.com>
>>
>>>   Fixed a bug in isKnownShuffleVector() which may cause assertion
>>> problem. Please review.
>>>
>>> http://llvm-reviews.chandlerc.com/D2542
>>>
>>> CHANGE SINCE LAST DIFF
>>>   http://llvm-reviews.chandlerc.com/D2542?vs=6428&id=6454#toc
>>>
>>> Files:
>>>   lib/Target/AArch64/AArch64ISelLowering.cpp
>>>   lib/Target/AArch64/AArch64ISelLowering.h
>>>   test/CodeGen/AArch64/neon-copy.ll
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>>
>>
>>
>> --
>> Thanks,
>> -Jiangning
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>


-- 
Best Regards,

Kevin Qin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140123/c517d2c8/attachment.html>