[patch] Quick try at fixing pr18515

Hal Finkel hfinkel at anl.gov
Wed Jan 22 09:09:04 PST 2014


----- Original Message -----
> From: "Rafael EspĂ­ndola" <rafael.espindola at gmail.com>
> To: "llvm-commits" <llvm-commits at cs.uiuc.edu>
> Cc: "Hal Finkel" <hfinkel at anl.gov>
> Sent: Friday, January 17, 2014 1:20:28 AM
> Subject: [patch] Quick try at fixing pr18515
> 
> I got curious as to what was needed to fix pr18515 and decided to try
> to patch it. This patch is under the following assumptions I got from
> reading the existing code
> 
> * most ppc cpus have a "sync n" instruction and an msync alias that
> is "sync 0".
> * "book e" cpus instead have a msync instruction and not the more
> general "sync n"
> 
> What this patch does is predicate the sync instruction and its
> aliases
> by IsNotBookE and then add a MSYNC instruction predicated on IsBookE.

This sounds about right. LGTM. Thanks for cleaning this up!

 -Hal

> 
> Cheers,
> Rafael
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory




More information about the llvm-commits mailing list