[PATCH] ARM IAS: support .movsp

Saleem Abdulrasool compnerd at compnerd.org
Mon Jan 20 18:53:15 PST 2014



================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:170
@@ +169,3 @@
+         "the operand of .movsp cannot be either sp or pc");
+  assert(UsedFP && ".setfp must precede .movsp");
+
----------------
Logan Chien wrote:
> This line will cause compilation error.
Yes, that line should not be there.

================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:169
@@ +168,3 @@
+  assert((Reg != ARM::SP && Reg != ARM::PC) &&
+         "the operand of .movsp cannot be either sp or pc");
+  assert(UsedFP && ".setfp must precede .movsp");
----------------
Logan Chien wrote:
> It seems that you have added these assertions to address Renato's comments.  However, I feel this is not necessary.  IMO, the assembler which will assemble the generated assembly will perform such check.  How do you think, Renato?
Yes, the assembler will perform this check.  This is simply asserting that we do not end up here in that case.


http://llvm-reviews.chandlerc.com/D2530



More information about the llvm-commits mailing list