[PATCH] Create a hook in the TargetHandler to find out which atoms need to have dynamic symbol table entry

[Shankar Easwaran]

On 1/19/2014 7:39 AM, Simon Atanasyan wrote:
>    Hi Shankar,
>
>    Thanks for the comment.
>
>    Could you please clarify a bit more why this design is a problem in case of -Bsymbolic option? I ask you because the patch in fact does not change the core lld functionality and just:
>    - Joins and factors out the export condition checking from `DynamicLibraryWriter::buildDynamicSymbolTable` and `OutputELFWriter::buildDynamicSymbolTable` to the `DefaultTargetHandler::needsDynSymEntry`
If there is an entry in the .got that doesnot make it to the .dynsym 
table automatically right ?

>    - Leaves the `OutputELFWriter<ELFT>::buildDynamicSymbolTable` as the only place where we build dynamic symbol table.
>
>    Anyway, in general I like your idea to subclass a writer for targets. When do you plan to finish your work?
I am nearly done, I am analyzing few test failures. Once I am through 
it, it will be easy to add target specific functionality to both the 
Reader/Writer.

Thanks

Shankar Easwaran