[PATCH] ARM IAS: add support for .unwind_raw directive

[Logan Chien]

  LGTM when following minor issue is addressed.


================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:259
@@ -256,1 +258,3 @@
 
+void ARMTargetAsmStreamer::emitUnwindRaw (int64_t Offset,
+                                      const SmallVectorImpl<uint8_t> &Opcodes) {
----------------
Please remove the space between the function name and the parenthesis.

================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:260
@@ +259,3 @@
+void ARMTargetAsmStreamer::emitUnwindRaw (int64_t Offset,
+                                      const SmallVectorImpl<uint8_t> &Opcodes) {
+  OS << "\t.unwind_raw " << Offset;
----------------
Is this line properly indented?

================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:396
@@ -383,1 +395,3 @@
+  virtual void emitUnwindRaw(int64_t Offset,
+                          const SmallVectorImpl<uint8_t> &Opcodes);
 
----------------
Is this line properly indented?

================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:673
@@ +672,3 @@
+void ARMTargetELFStreamer::emitUnwindRaw(int64_t Offset,
+                                      const SmallVectorImpl<uint8_t> &Opcodes) {
+  getStreamer().emitUnwindRaw(Offset, Opcodes);
----------------
Is this line properly indented?

================
Comment at: test/MC/ARM/eh-directive-unwind_raw-diagnostics.s:1
@@ +1,2 @@
+@ RUN: not llvm-mc -triple armv7-eabi -filetype asm -o /dev/null 2>&1 %s \
+@ RUN:   | FileCheck %s
----------------
As in previous patch, I would suggest to use armv7-linux-gnueabi.

================
Comment at: test/MC/ARM/eh-directive-unwind_raw.s:1
@@ +1,2 @@
+@ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s | llvm-readobj -u \
+@ RUN:   | FileCheck %s
----------------
Here too.


http://llvm-reviews.chandlerc.com/D2541