[PATCH] ARM IAS: support .personalityindex

Logan Chien tzuhsiang.chien at gmail.com
Sun Jan 19 05:00:08 PST 2014



================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:8832
@@ +8831,3 @@
+  }
+  if (CE->getValue() < 0 || CE->getValue() >= 3) {
+    Parser.eatToEndOfStatement();
----------------
Renato Golin wrote:
> Logan Chien wrote:
> > I would prefer to use:
> > CE->getValue() < ARM::AEABI::NUM_PERSONALITY_INDEX
> Good point. I agree.
Oops.  I gave the incorrect code.  The correct one should be:

    if (CE->getValue() < 0 || CE->getValue() >= ARM::EHABI::NUM_PERSONALITY_INDEX) {


http://llvm-reviews.chandlerc.com/D2525



More information about the llvm-commits mailing list