[PATCH] Create a hook in the TargetHandler to find out which atoms need to have dynamic symbol table entry

Simon Atanasyan simon at atanasyan.com
Sun Jan 19 05:39:22 PST 2014


  Hi Shankar,

  Thanks for the comment.

  Could you please clarify a bit more why this design is a problem in case of -Bsymbolic option? I ask you because the patch in fact does not change the core lld functionality and just:
  - Joins and factors out the export condition checking from `DynamicLibraryWriter::buildDynamicSymbolTable` and `OutputELFWriter::buildDynamicSymbolTable` to the `DefaultTargetHandler::needsDynSymEntry`
  - Leaves the `OutputELFWriter<ELFT>::buildDynamicSymbolTable` as the only place where we build dynamic symbol table.

  Anyway, in general I like your idea to subclass a writer for targets. When do you plan to finish your work?

http://llvm-reviews.chandlerc.com/D2574



More information about the llvm-commits mailing list