[PATCH] tools: support decoding ARM EHABI opcodes in readobj
Saleem Abdulrasool
compnerd at compnerd.org
Sun Jan 19 12:30:47 PST 2014
Thanks for the additional test case Logan! I have added that and it does now decode correctly. I will update the patch for the spare decoding as well and then repost. Thank you very much for the close inspection.
================
Comment at: tools/llvm-readobj/ARMEHABIPrinter.h:273
@@ +272,3 @@
+ if (!Decoded)
+ SW.startLine() << format("0x%02X ; reserved\n", Opcodes[OCI++ ^ 3]);
+ }
----------------
Renato Golin wrote:
> You seem to be missing the spare encodings and treating as reserved. That's ok, but would be good to include it in the text above, like "reserved/spare".
I think that adding the spare cases shouldn't be too bad. Ill see if I can add those otherwise I will update the text.
http://llvm-reviews.chandlerc.com/D2565
More information about the llvm-commits
mailing list