[PATCH] [AArch64 NEON] Accept both #0.0 and #0 for comparing with floating point zero in asm parser.

Jiangning Liu liujiangning1 at gmail.com
Sun Jan 19 18:03:14 PST 2014


  Hi Kevin,

  This patch looks good to me!

  Thanks,
  -Jiangning


  2014/1/7 Kevin Qin <kevinqindev at gmail.com>

  >   Hi Tim,
  >
  >   Sorry for updated late since last patch. We consider to let asm parser
  > accept #0x0 as well. It means #0.0, #0 and #0x0 will be valid immediate for
  > FCMXX. Also made some changes to simplify codes and get diagnostics more
  > readable. Please review again, thanks.
  >
  > http://llvm-reviews.chandlerc.com/D2432
  >
  > CHANGE SINCE LAST DIFF
  >   http://llvm-reviews.chandlerc.com/D2432?vs=6157&id=6377#toc
  >
  > Files:
  >   lib/Target/AArch64/AArch64InstrNEON.td
  >   lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
  >   test/MC/AArch64/neon-compare-instructions.s
  >   test/MC/AArch64/neon-diagnostics.s
  >   test/MC/AArch64/neon-scalar-fp-compare.s
  >
  > _______________________________________________
  > llvm-commits mailing list
  > llvm-commits at cs.uiuc.edu
  > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
  >
  >

http://llvm-reviews.chandlerc.com/D2432



More information about the llvm-commits mailing list