[llvm] r197988 - llvm-symbolizer: add --obj flag to specify a single object file that should be symbolized.

[Alexey Samsonov]

On Thu, Jan 16, 2014 at 3:17 AM, Ed Maste <emaste at freebsd.org> wrote:
> On 15 January 2014 08:06, Ed Maste <emaste at freebsd.org> wrote:
>> However that still leaves types -- I think llvm-symbolizer would
>> return "float" for a function "f".  The test input used for the --obj
>> flag helpfully has a function named "f" already, so I used that for an
>> additional test - perhaps someone can try it on another platform.
>
> I've confirmed the llvm-symbolizer issue on OS X as well.  It turns
> out I somehow missed that llvm-symbolizer already has heuristic for
> demangled names, but applies it only to global data, not function
> names.
>
> I've moved it into DemangleName, and updated the review at
> http://llvm-reviews.chandlerc.com/D2552

Yes, I think that change makes sense. Thanks for looking into this!

>
> I also added a new C language test for this case.  I was going to
> modify dwarfdump-test.cc to have an extern "C", but decided against
> changing it as it would no longer match the checked-in binaries that
> were generated from it.



-- 
Alexey Samsonov, MSK