[Patch] [Thumbv8] Fix tje default value of BLXOperandIndex of isV8EligibleForIT

[Weiming Zhao]

Ping?

 

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

 

From: Weiming Zhao [mailto:weimingz at codeaurora.org] 
Sent: Friday, January 10, 2014 3:43 PM
To: llvm-commits at cs.uiuc.edu
Subject: RE: [Patch] [Thumbv8] Fix tje default value of BLXOperandIndex of
isV8EligibleForIT

 

Ping?

 

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

 

From: Weiming Zhao [mailto:weimingz at codeaurora.org] 
Sent: Friday, January 03, 2014 11:58 AM
To: llvm-commits at cs.uiuc.edu
Subject: [Patch] [Thumbv8] Fix tje default value of BLXOperandIndex of
isV8EligibleForIT

 

Hi,

 

Function isV8EligibleForIT(InstrType *Instr, int BLXOperandIndex = 0) has 2
call sites:

ARMBaseInstrInfo.cpp:      return isV8EligibleForIT(MI);  è this one should
pass the 2nd parameter with value 2 (just like the other call)

AsmParser/ARMAsmParser.cpp:          !isV8EligibleForIT(&Inst, 2))

 

Below is an example of MCInst for “blx r8”:

blx r8:

@ <MCInst #2747 tBLXr

@ <MCOperand Imm:14>

@ <MCOperand Reg:0>

@ <MCOperand Reg:74> ==> this is the operand to be checked

 

Since there are only 2 call sites, this patch changes the default value of
BLXOperandIndex to 2 instead of 0.

 

See http://llvm.org/bugs/show_bug.cgi?id=18368 for the bug.

 

Please review the patch.

 

Thanks,

Weiming

 

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140115/6466abf0/attachment.html>