[llvm] r196607 - Integrated assembler incorrectly lexes ARM-style comments

David Peixotto dpeixott at codeaurora.org
Wed Jan 15 14:45:55 PST 2014


> On Wed, Jan 15, 2014 at 12:37:28PM +0000, Renato Golin wrote:
> > On 15 January 2014 10:39, Joerg Sonnenberger
> <joerg at britannica.bec.de>wrote:
> >
> > > It serves the purpose and as long as the person responsible for the
> > > use of @ as start-of-comment gets the proper amount of force
> applied...
> > >
> >
> > I don't think this is going to change soon, unless both Clang and GCC
> > deprecate it together.
> >
> > Does the patch look good to you, Joerg?
> 
> Yes.

Thanks everyone for the helpful reviews. Committed in r199339.




More information about the llvm-commits mailing list