[llvm] r199245 - Fix a low hanging use of hasRawTextSupport.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Jan 14 18:48:52 PST 2014


> The problem appears to be that symbols are being marked micromips when they should not be.
>
> Reverting r199245 and r199181 fixes the issues.
>
> Is it OK if we revert these changes and then diagnose the issue at hand?

It is not r199245, since that one only change how assembly is printed.
The object streamer methods are stubs.

r199181 is a good candidate. I am a bit reluctant to revert it now
that I know that the old streamer API doesn't match what gas does and
patches using it were being proposed.The issue is very likely a
missing .set nomicromips that would show up when using gas. Would you
mind doing a few tests first?

What symbols are incorrectly marked as micromips? Other functions? Can
you test the attached patch? The comment is out of date (I found about
the syntax in the gas manual after all) and with it we will disable
micromips before printing a function that doesn't use it.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 622 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140114/1d559418/attachment.obj>


More information about the llvm-commits mailing list