[PATCH] PR 18466: Fix ARM Pseudo Expansion
Weiming Zhao
weimingz at codeaurora.org
Tue Jan 14 17:38:02 PST 2014
Hi Tim,
Thanks for review.
I fixed the formatting and commited as r199282
Thanks,
Weiming
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
-----Original Message-----
From: Tim Northover [mailto:t.p.northover at gmail.com]
Sent: Tuesday, January 14, 2014 1:00 AM
To: Weiming Zhao
Cc: llvm-commits
Subject: Re: [PATCH] PR 18466: Fix ARM Pseudo Expansion
Hi Weiming,
> Currently, ARM Pseudo expansion for NEON misses implicit uses for src
> regs in some cases, which may eventually result into mis-scheduling (post-RA).
Generally the patch looks good. There's some slightly dodgy indentation though, with "if" and "else" indented on separate lines.
Other than that, I think you can just commit.
Cheers.
Tim.
More information about the llvm-commits
mailing list