[LNT] r199271 - Sane default for --commit in lnt submit

[Chris Matthews]

Author: cmatthews
Date: Tue Jan 14 17:24:20 2014
New Revision: 199271

URL: http://llvm.org/viewvc/llvm-project?rev=199271&view=rev
Log:
Sane default for --commit in lnt submit

Lnt submit is used for sending results to the server, so having the default behavior be not submitting is confusing to users.  This patch changes the default to commit=1, so results are submitted, and adds a warning if submit is called with commit=0 so that you know your results will not be stored on the server.

Modified:
    lnt/trunk/lnt/lnttool/main.py

Modified: lnt/trunk/lnt/lnttool/main.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/lnttool/main.py?rev=199271&r1=199270&r2=199271&view=diff
==============================================================================
--- lnt/trunk/lnt/lnttool/main.py (original)
+++ lnt/trunk/lnt/lnttool/main.py Tue Jan 14 17:24:20 2014
@@ -178,7 +178,7 @@ def action_submit(name, args):
     parser.add_option("", "--commit", dest="commit", type=int,
                       help=("whether the result should be committed "
                             "[%default]"),
-                      default=False)
+                      default=True)
     parser.add_option("-v", "--verbose", dest="verbose",
                       help="show verbose test results",
                       action="store_true", default=False)
@@ -187,6 +187,10 @@ def action_submit(name, args):
     if len(args) < 2:
         parser.error("incorrect number of argments")
 
+    if not opts.commit:
+        warning("submit called with --commit=0, your results will not be saved"
+                " at the server.")
+
     from lnt.util import ServerUtil
     ServerUtil.submitFiles(args[0], args[1:], opts.commit, opts.verbose)