[PATCH] Move arm assembler constant pools to ARMTargetStreamer class

[Renato Golin]

On 13 January 2014 18:34, David Peixotto <dpeixott at codeaurora.org> wrote:

> Ping. Any feedback on the patch/approach? What do people think about
> storing
> the constant pools in the ARMTargetStreamer class?
>

Hi David,

Sorry for the delay.

I think it's a good idea to have an object handling the constant pools,
that would enable us to merge multiple pools, de-duplicate, etc.

But the new ARMTargetMachOStreamer class being all but the constant pool is
a bit too much, I think. The fact that the ASM streamer and the object
streamer are separated is a mess, but we shouldn't add more to it.

I have to say I lost touch with how the streamers are being used in the
grand scheme of things, but I believe only the asm parser is now using that
streamer and should move to the one the back-end is actually using. Rafael
should know more...


cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140114/fe782a8a/attachment.html>