[PATCH] ARM IAS: support .personalityindex
Renato Golin
renato.golin at linaro.org
Tue Jan 14 06:09:55 PST 2014
================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:8832
@@ +8831,3 @@
+ }
+ if (CE->getValue() < 0 || CE->getValue() >= 3) {
+ Parser.eatToEndOfStatement();
----------------
Logan Chien wrote:
> I would prefer to use:
> CE->getValue() < ARM::AEABI::NUM_PERSONALITY_INDEX
Good point. I agree.
================
Comment at: lib/Target/ARM/MCTargetDesc/ARMUnwindOpAsm.cpp:199
@@ +198,3 @@
+ if (PersonalityIndex == ARM::EHABI::NUM_PERSONALITY_INDEX)
+ PersonalityIndex = Ops.size() <= 3 ? ARM::EHABI::AEABI_UNWIND_CPP_PR0
+ : ARM::EHABI::AEABI_UNWIND_CPP_PR1;
----------------
Renato Golin wrote:
> use of parenthesis here would be clearer.
Here, too, the use of ARM::AEABI::NUM_PERSONALITY_INDEX.
http://llvm-reviews.chandlerc.com/D2525
More information about the llvm-commits
mailing list