[llvm] r199076 - [CMake] Move BUG_REPORT_URL from clang to llvm.

[NAKAMURA Takumi]

Greg,

Sure, that is! I closed it. Thanks!

2014/1/13 Greg Bedwell <gregbedwell at gmail.com>:
> Hi,
>
> From the sounds of the commit message it sounds like this this fixes PR13306
> ("Must run CMake twice before building").  Do you agree?
> http://llvm.org/bugs/show_bug.cgi?id=13306
>
> Thanks,
>
> Greg Bedwell
> SN Systems Ltd - Sony Computer Entertainment Group
>
>
>
> On 13 January 2014 05:25, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>>
>> Author: chapuni
>> Date: Sun Jan 12 23:25:13 2014
>> New Revision: 199076
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=199076&view=rev
>> Log:
>> [CMake] Move BUG_REPORT_URL from clang to llvm.
>>
>> It was too late to set BUG_REPORT_URL after configure_file(config.h).
>> BUG_REPORT_URL in config.h.cmake would be updated at 2nd run of cmake.
>> It caused many recompilations.
>>
>> FYI, configure handles BUG_REPORT_URL in llvm side.
>>
>> Modified:
>>     llvm/trunk/CMakeLists.txt
>>
>> Modified: llvm/trunk/CMakeLists.txt
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=199076&r1=199075&r2=199076&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/CMakeLists.txt (original)
>> +++ llvm/trunk/CMakeLists.txt Sun Jan 12 23:25:13 2014
>> @@ -37,6 +37,9 @@ set(PACKAGE_NAME LLVM)
>>  set(PACKAGE_STRING "${PACKAGE_NAME} ${PACKAGE_VERSION}")
>>  set(PACKAGE_BUGREPORT "http://llvm.org/bugs/")
>>
>> +set(BUG_REPORT_URL "${PACKAGE_BUGREPORT}" CACHE STRING
>> +  "Default URL where bug reports are to be submitted.")
>> +
>>  # Configure CPack.
>>  set(CPACK_PACKAGE_INSTALL_DIRECTORY "LLVM")
>>  set(CPACK_PACKAGE_VENDOR "LLVM")
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>