[PATCH][MC/X86_64] Implement Win64 exception handling

Kai Nacke kai.nacke at redstar.de
Sun Jan 12 22:53:54 PST 2014


Hi Nico!

On 10.01.2014 12:42, Nico Rieck wrote:
> Hello Kai!
>
> +  case X86::LEA64r:
> ...
> +    if (SReg == RI->getStackRegister()) {
> +      assert(Offset < 0 && "Offset must be negativ");
>
> While fixing PR16779 I noticed that I had this backwards. Offsets here
> actually must be *positive*! Sorry for the confusion. So LEA cannot be
> used instead of a SUB, and I'll disallow it for atom on Win64.

I rechecked what MSVC emits. Indeed the offset is positive. I change this.

Nice to hear that you are working on PR16779!

Regards,
Kai

>
> -Nico
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>





More information about the llvm-commits mailing list