[llvm] r196607 - Integrated assembler incorrectly lexes ARM-style comments

Joerg Sonnenberger joerg at britannica.bec.de
Sun Jan 12 12:36:27 PST 2014


On Fri, Jan 10, 2014 at 06:24:19PM -0800, David Peixotto wrote:
> Modifying the Lexer to allow @ in the symbol for that one directive was
> relatively easy. The harder part was only doing it for ARM in the
> ELFAsmParser. Any feedback to improve the patch is appreciated.

What about using two flags. The basic AllowAtInIdentifiers as static and
derived from the comment char. A second flag for AllowAtInNextIdentifier
which is only set by .symvar and reset again. That completely removes
the need to special case ARM.

Joerg



More information about the llvm-commits mailing list