[PATCH] [ARM] Fix required ISA for multiplication instructions

Renato Golin renato.golin at linaro.org
Sun Jan 12 06:20:25 PST 2014


Hi Joerg,

>From all I know about the early clobber flag in the table gen, your second
patch looks fine.

Your first patch also looks fine, though SMLALxy is not supported in ARMv4,
so you should move its tests to something v5 and use Subtarget.hasV5TEOps().

Before committing, I'd welcome reviews from Tim and Richard, just to make
sure I'm not missing anything.

cheers,
--renato


On 12 January 2014 03:41, Joerg Sonnenberger <joerg at britannica.bec.de>wrote:

> On Sun, Jan 12, 2014 at 03:00:51AM +0100, Joerg Sonnenberger wrote:
> > while looking at building NetBSD for older ARM ISAs, I hit the issue
> > that MC belives that umlal and friends are v6+ only. There seems to be
> > no reason for the complications in the matching, so just drop it.
>
> Further analysis shows that this is likely a bug in the patterns.
> Can someone with more ARM knowledge please verify the attached patch?
>
> Joerg
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140112/2d2af4e0/attachment.html>


More information about the llvm-commits mailing list