[PATCH] [prototype] Adding line table debug information to LLVM on Windows

[Eric Christopher]

  Go ahead and fix the conditional as I've mentioned below so we don't regress cygwin and mingw and it's OK with me.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:198
@@ -195,3 +197,3 @@
   if (MAI->doesSupportDebugInformation()) {
-    DD = new DwarfDebug(this, &M);
-    Handlers.push_back(HandlerInfo(DD, DbgTimerName, DWARFGroupName));
+    if (Triple(TM.getTargetTriple()).isOSWindows()) {
+      Handlers.push_back(HandlerInfo(new WinCodeViewLineTables(this),
----------------
Eric Christopher wrote:
> I'm not sure this is the right conditional for this - at the very least it should be possible to continue with dwarf information on windows and this isn't going to let it. Possibly a command line option?
You need to use Triple(Tm.getTargetTriple()).getOS() == Triple::Win32 here, otherwise you're turning this on for cygwin and mingw and right now those support dwarf just fine and it's fairly expected there.


http://llvm-reviews.chandlerc.com/D2232