REQUIRES_FRAME_POINTER

[Eric Christopher]

Yup. Patch is fine then. Assuming you have commit access?

-eric

On Fri Jan 10 2014 at 12:50:16 PM, Gaël Thomas <gael.thomas00 at gmail.com>
wrote:

> Exactly :) clang assumes -fomit-frame-pointer with -O3 on linux/x86_64,
>
> Gaël
> Le 10 janv. 2014 21:36, "Eric Christopher" <echristo at gmail.com> a écrit :
>
> It's definitely what's expected, basically working around compilers that
> assume -fomit-frame-pointer by default?
>
> -eric
>
> On Fri Jan 10 2014 at 7:12:02 AM, Rafael Espíndola <
> rafael.espindola at gmail.com> wrote:
>
> Seems reasonable. CCing Eric who is the code owner of configure/make
> build system.
>
> On 23 December 2013 14:56, Gaël Thomas <gael.thomas00 at gmail.com> wrote:
> > Hi all,
> >
> > I made a small patch to modify the file Makefile.rules when the flag
> > REQUIRES_FRAME_POINTER is used. In this case, I have added the
> > -fno-omit-frame-pointer flag to force the use of the frame pointer.
> > It's mandatory for vmkit, which supposes that all the frames are
> > "well" formed in the sense that they use frame pointers (we rely on
> > the frame pointers to inspect the stack during a collection). As the
> > flag already exists, I think that forcing frame pointers is exactly
> > what the user could expect, even when the code is optimized?
> >
> > See you,
> > Gaël
> >
> >
> >
> > --
> > -------------------------------------------------------------------
> > Gaël Thomas, Associate Professor, UPMC
> > http://pagesperso-systeme.lip6.fr/Gael.Thomas/
> > -------------------------------------------------------------------
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140110/7ce5b9ca/attachment.html>