[PATCH] [prototype] Adding line table debug information to LLVM on Windows

[Timur Iskhodzhanov]

As we've discussed on llvm-dev earlier, we'll choose the debug info format
based on the triple for now (to simplify things) but may add a command line
option later when needed.

Are you OK if I just add a FIXME before the condition for now?
09 янв. 2014 г. 18:11 пользователь "Eric Christopher" <echristo at gmail.com>
написал:

>
>   Looks pretty good, thanks.
>
>   I'd prefer you split out the MC bit when you commit, just because it's
> not necessary as part of this. One other comment below.
>
>
> ================
> Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:198
> @@ -195,3 +197,3 @@
>    if (MAI->doesSupportDebugInformation()) {
> -    DD = new DwarfDebug(this, &M);
> -    Handlers.push_back(HandlerInfo(DD, DbgTimerName, DWARFGroupName));
> +    if (Triple(TM.getTargetTriple()).isOSWindows()) {
> +      Handlers.push_back(HandlerInfo(new WinCodeViewLineTables(this),
> ----------------
> I'm not sure this is the right conditional for this - at the very least it
> should be possible to continue with dwarf information on windows and this
> isn't going to let it. Possibly a command line option?
>
>
> http://llvm-reviews.chandlerc.com/D2232
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140110/fe545321/attachment.html>