[PATCH] Must not produce Tag_CPU_arch_profile for pre-ARMv7 cores

[Artyom Skrobov]

Thank you James -- some further comments:

> I agree with Saleem that this should be two patches. That said, I've
> reviewed the main patch (I ignored thumbv7m.s and thumb2-mclass.s
> for the purposes of this review).

Would you please review the changes to thumb2-mclass.s too?
Yourself being the original creator of that test case.

> I think a comment above here as to why this is conditional on v7+ would
> be useful.

Fair enough -- will add.

> An } else { llvm_unreachable(); } block seems required to check at least
> one of A, R or M was picked.

I'm not so sure: specifying "armv7" or "thumbv7" target results in selecting
the "generic" CPU, with none of {aclass,rclass,mclass} -- see
ARM_MC::ParseARMTriple for details.
This might be a separate issue to be fixed, or this might relate to the
"cross-profile code" provision in the ABI addenda -- I'm not sure.