[llvm] r196607 - Integrated assembler incorrectly lexes ARM-style comments

Joerg Sonnenberger joerg at britannica.bec.de
Thu Jan 9 16:52:53 PST 2014


On Fri, Dec 06, 2013 at 08:35:58PM -0000, David Peixotto wrote:
> Author: dpeixott
> Date: Fri Dec  6 14:35:58 2013
> New Revision: 196607
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=196607&view=rev
> Log:
> Integrated assembler incorrectly lexes ARM-style comments
> 
> The integrated assembler fails to properly lex arm comments when
> they are adjacent to an identifier in the input stream. The reason
> is that the arm comment symbol '@' is also used as symbol variant in
> other assembly languages so when lexing an identifier it allows the
> '@' symbol as part of the identifier.

This has broken .symver for ELF targets on ARM. Do you plan to fix this?
Otherwise I'd ask for a revert.

Joerg



More information about the llvm-commits mailing list