[PATCH] Fix Remote MCJIT protocol

[Alp Toker]

On 09/01/2014 20:56, Renato Golin wrote:
> On 9 January 2014 19:29, Alp Toker <alp at nuanti.com 
> <mailto:alp at nuanti.com>> wrote:
>
>     Drive-by comment: Can you move all the rc asserts into a single
>     check within ReadBytes()?
>
>     They seem to check the same thing -- that the requested number of
>     bytes was actually read.
>
>
> Right, good point. Will do that. I didn't want to change much in 
> ChildTarget, since it was going to die, but I can make some amends, 
> even if it gets killed in the process later on.

Agree totally that this change doesn't need to be perfect. Some of it 
should go away shortly, but it's great to have the existing setup 
known-good and passing on ARM builders before moving forward.

The rc suggestion ought to survive the cleanup, so if it's an easy 
picking it's worth getting done.

Your changes are complementary to the cleanup I'd proposed, so thanks on 
that :-)

+1 on the general approach. Handing over to the code owners for a proper 
review..

Alp.


>
> --renato

-- 
http://www.nuanti.com
the browser experts