[PATCH] Fix Remote MCJIT protocol

Alp Toker alp at nuanti.com
Thu Jan 9 11:29:47 PST 2014


On 09/01/2014 19:23, Renato Golin wrote:
>   void LLIChildTarget::handleExecute() {
>     // Read the message data size.
>     uint32_t DataSize;
>     int rc = ReadBytes(&DataSize, 4);
> +  (void)rc;
>     assert(rc == 4);
>     assert(DataSize == 8);

Drive-by comment: Can you move all the rc asserts into a single check 
within ReadBytes()?

They seem to check the same thing -- that the requested number of bytes 
was actually read.

Alp.

-- 
http://www.nuanti.com
the browser experts




More information about the llvm-commits mailing list