[llvm] r198854 - Revert r198819 - "Remove dead code."

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Jan 9 05:48:34 PST 2014


On 9 January 2014 02:50, Nadav Rotem <nrotem at apple.com> wrote:
> Author: nadav
> Date: Thu Jan  9 01:50:34 2014
> New Revision: 198854
>
> URL: http://llvm.org/viewvc/llvm-project?rev=198854&view=rev
> Log:
> Revert r198819 - "Remove dead code."

Hi Nadav,
This code *is* dead. I has no in tree users and we normally don't keep
API around for out of tree users. In addition, it is incomplete (no 16
bit pointers, no address spaces) and duplicates code from DataLayout.

I will remove this again this afternoon if I don't get a strong reason
for why we should keep it. If you have out of tree uses you can copy
this there, but my suggestion would be to just use DataLayout. Look at
clang r198815 for an example.

Cheers,
Rafael



More information about the llvm-commits mailing list