[PATCH] ARM IAS: support GNU extension for ldrd, strd

Renato Golin renato.golin at linaro.org
Thu Jan 9 01:52:11 PST 2014


  Hi Saleem,

  Just add some comments about GNU-compatibility and looks good to me.

  cheers,
  --renato


================
Comment at: lib/Target/ARM/ARMInstrInfo.td:2282
@@ +2281,3 @@
+
+  let isAsmParserOnly = 1 in
+    def LDRD_PAIR : AI3ld<0b1101, 0, (outs GPRPairOp:$Rt), (ins addrmode3:$addr),
----------------
Please, add a comment saying this is a GNU-extension.

================
Comment at: lib/Target/ARM/ARMInstrInfo.td:2548
@@ -2542,1 +2547,3 @@
 
+  let isAsmParserOnly = 1 in
+    def STRD_PAIR : AI3str<0b1111, (outs), (ins GPRPairOp:$Rt, addrmode3:$addr),
----------------
Here too.

================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:5394
@@ -5393,1 +5393,3 @@
 
+  if ((Mnemonic == "ldrd" || Mnemonic == "strd") && !isThumb() &&
+      Operands.size() == 4) {
----------------
Here too.


http://llvm-reviews.chandlerc.com/D2512



More information about the llvm-commits mailing list