[PATCH] Simplify format of profile input file.
Diego Novillo
dnovillo at google.com
Tue Jan 7 15:18:21 PST 2014
On Tue, Jan 7, 2014 at 5:48 PM, Chandler Carruth <chandlerc at gmail.com> wrote:
>
> Looks good, one comment tweak below.
>
>
> ================
> Comment at: lib/Transforms/Scalar/SampleProfile.cpp:434-441
> @@ +433,10 @@
> +
> + // Now read the body. Each line in the function body has this
> + // format:
> + //
> + // line_offset[.discriminator]: number_of_samples [fn1:num fn2:num ... ]
> + //
> + // See above for an explanation of each field. The body of the
> + // function ends when we reach EOF or when we see the start of the
> + // next function.
> + while (!LineIt.is_at_eof() && isdigit((*LineIt)[0])) {
> ----------------
> I would probably just assume the reader read the introductory comment and condense this as:
>
> // Now read the body. The body of the function ends when we reach EOF
> // or when we see the start of the next function.
Done.
I can't actually commit this part until the other two patches are reviewed:
http://llvm-reviews.chandlerc.com/D2355
http://llvm-reviews.chandlerc.com/D2274
Thanks.
More information about the llvm-commits
mailing list