[PATCH] Introduce a cmake LLVM_ENABLE_LIBCXX build parameter to compile using libc++ instead of the system default

[Timur Iskhodzhanov]

2014/1/7 Chandler Carruth <chandlerc at google.com>:
> FWIW, this patch is fine.
>
> Don't stress too much about this.
>
> Of course, its nice to remind folks if they should wait for another review,

That was the point.

> but I think this patch is simple enough and low enough risk that anyone who
> understands CMake and can test it should feel fine providing an LGTM.

Agreed.
Probably such a justification should have been used then :)

> =]
>
>
> On Tue, Jan 7, 2014 at 3:40 AM, Timur Iskhodzhanov <timurrrr at google.com>
> wrote:
>>
>> Am I reading it right that this patch was committed without a review by an
>> approved reviewer (partly) because you weren't explicit enough?
>>
>> 07 янв. 2014 г. 3:51 пользователь "João Matos" <ripzonetriton at gmail.com>
>> написал:
>>
>>> Hi Timur,
>>>
>>> No, I am not an approved reviewer, I only commented the changes to give
>>> some feedback about those changes, and maybe bring some attention to this
>>> forgotten patch.  There's an explicit option to accept the revision in Phab
>>> which I did not use.
>>>
>>>
>>> On Mon, Jan 6, 2014 at 9:52 PM, Timur Iskhodzhanov <timurrrr at google.com>
>>> wrote:
>>>>
>>>> Joao,
>>>>
>>>> Are you an approved reviewer for this part of the codebase?
>>>>
>>>> 2014/1/6 João Matos <ripzonetriton at gmail.com>:
>>>> >
>>>> >   LGTM.
>>>> >
>>>> >   I've tested the patch and was able to complete a C++11 LLVM build
>>>> > with CMake on OSX.
>>>> >
>>>> > http://llvm-reviews.chandlerc.com/D2381
>>>> > _______________________________________________
>>>> > llvm-commits mailing list
>>>> > llvm-commits at cs.uiuc.edu
>>>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>>
>>>
>>>
>>> --
>>> João Matos
>
>