[PATCH] enable stackmap generation for ELF

Kevin Modzelewski kmod at dropbox.com
Mon Jan 6 15:23:41 PST 2014


Hi, I've rebased the patch to the current trunk and removed some of the
test cases.  Could you take a look and/or commit when you have a chance?
 There's also Jorg's patch which is the same thing :)

I'm parsing the stackmaps during JITEventListener::NotifyObjectEmitted(),
which gets passed an ObjectImage from which I can pull the stackmaps
section; not sure if that works differently with different object formats,
but if it works it feels a little more natural to me.


On Tue, Dec 17, 2013 at 11:11 AM, Lang Hames <lhames at gmail.com> wrote:

> Hi Kevin, Andy,
>
> > ... I had originally not added the SHF_ALLOC flag to the section which
> meant that it didn't get allocated through the MemoryManager at all, but
> regardless it still ends up in the emitted object file.
>
> The StackMap section not getting allocated through the MemoryManager might
> be considered a bug, regardless of the SHF_ALLOC setting. I'm going to
> discuss that with some people who are more familiar with MemoryManager.
>
> Ideally, the stack map section should not need to be loaded. i.e. it would
>> be nice to avoid making a copy of it. But the MCJIT client does not
>> necessarily know how to parse the object format, so I don’t know if WebKit
>> could use an event listener. Maybe Lang can answer this better.
>>
>
> For now I'd say "whatever works". I'm doing some investigation now to try
> to figure out the right way to deal with this going forward - the
> deprecation of the old JIT may mean that some of this infrastructure
> changes or goes away.
>
> - Lang.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140106/bbc19762/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: enable_elf_stackmaps_2.patch
Type: text/x-patch
Size: 6196 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140106/bbc19762/attachment.bin>


More information about the llvm-commits mailing list