[PATCH] [AArch64 NEON] Fix wrong imm used in BIC instruction.

Tim Northover t.p.northover at gmail.com
Mon Jan 6 06:06:50 PST 2014


  Hi Kevin,

  I've got a quick question about the DAG being matched. I suspect the issue has been there a while, but it looks very iffy:


================
Comment at: lib/Target/AArch64/AArch64InstrNEON.td:1223
@@ -1222,3 +1222,1 @@
                     (v2i32 (opnode (v2i32 VPR64:$src),
-                      (v2i32 (bitconvert (v2i32 (neonopnode timm:$Imm,
-                        neon_mov_imm_LSL_operand:$Simm)))))))],
----------------
What's creating this bitconvert? It's highly suspect since it's a NOP even at the DAG level. At worst it should be removed by DAGCombiner, at best it should never be created in the first place.


http://llvm-reviews.chandlerc.com/D2500



More information about the llvm-commits mailing list