[PATCH v2 02/14] [x86] Add basic support for .code16
Joerg Sonnenberger
joerg at britannica.bec.de
Sun Jan 5 13:31:47 PST 2014
On Sun, Jan 05, 2014 at 03:01:10PM -0600, Craig Topper wrote:
> Joerg, do you have a specific objections to anything in David's original
> patch that used two feature bits?
The reason for the initial objection was that the choosen mapping makes
it hard to ensure that all places copy the bits correctly. As such, both
bits 0 is a bad choice for a valid mode. I don't have a problem with
using two flag bits and a encoding of like 0 invalid, 1 16bit, 2 32bit,
3 64bit or some other permutation of the last three.
Joerg
More information about the llvm-commits
mailing list