[PATCH v2 02/14] [x86] Add basic support for .code16

Joerg Sonnenberger joerg at britannica.bec.de
Sun Jan 5 12:04:22 PST 2014


On Sun, Jan 05, 2014 at 07:32:36AM -0600, Craig Topper wrote:
> Is it possible to do this with only one new feature bit. Can we just have
> Mode16Bit and Mode64Bit with Mode32 implied if the others aren't set?

What I believe to be the correct approach is to have three explicit
predicates: is16BitMode, is32BitMode and is64BitMode. Whether they share
feature bits in the backend is of smaller concern to me, but I would
strongly prefer to not have as much implicit assumptions as currently
("!64 == 32"). How does that sound?

Joerg



More information about the llvm-commits mailing list