[PATCH] Replace nested switch statements.
Rui Ueyama
ruiu at google.com
Sat Jan 4 18:46:25 PST 2014
================
Comment at: lib/Driver/GnuLdDriver.cpp:151
@@ -132,22 +150,3 @@
std::string value(arg->getValue());
-
- switch (triple.getOS()) {
- case llvm::Triple::NetBSD:
- switch (triple.getArch()) {
- case llvm::Triple::x86:
- case llvm::Triple::x86_64:
- if (value == "elf_i386") {
- triple.setArch(llvm::Triple::x86);
- return true;
- }
- if (value == "elf_x86_64") {
- triple.setArch(llvm::Triple::x86_64);
- return true;
- }
- break;
- default:
- break;
- }
- break;
- default:
- break;
+ llvm::Optional<llvm::Triple::ArchType> arch = getArchType(triple, value);
+ if (!arch) {
----------------
Joerg Sonnenberger wrote:
> ...and pass down arg->getValue() directly.
Done.
http://llvm-reviews.chandlerc.com/D2501
More information about the llvm-commits
mailing list