[LNT] r198453 - In an effort refactor the code to make way for run resampling, move the run submission code into the test suites.

[Tobias Grosser]

On 01/04/2014 03:53 PM, Tobias Grosser wrote:
> On 01/03/2014 11:50 PM, Chris Matthews wrote:
>> Author: cmatthews
>> Date: Fri Jan  3 16:50:32 2014
>> New Revision: 198453
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=198453&view=rev
>> Log:
>> In an effort refactor the code to make way for run resampling, move
>> the run submission code into the test suites.
>>
>> With resampling the submission logic will change in NT.
>> Deprecate runtest command line args. Move submit code into common
>> subclass. Refactored out the result printing code, as it was common to
>> several places.
>
> Hi Chris,
>
> this change made the stdio of LNT a lot more verbose:
>
> compare:
>
> http://lab.llvm.org:8011/builders/polly-perf-O3/builds/435/steps/lnt.nightly-test/logs/stdio
>
>
> to
>
> http://lab.llvm.org:8011/builders/polly-perf-O3/builds/436/steps/lnt.nightly-test/logs/stdio
>
>
> We now print information that is already logged in configure.log and
> test.log. So there does not see any reason to also dump this to stdio.
> Also, it makes it very hard to get a high level idea of the test progress.
>
> Could you fix this quickly or revert it, in case we need to discuss this
> further.

Hi Chris,

I just figured that the commit broke in fact all LNT buildbots. Also, my 
previous fix was not enough to get them back.

I reverted your commit for now in r198496.

Maybe you could have a look into what needs to be changed to avoid such 
breakages.

Cheers,
Tobias