[lld] r198468 - [MachO] Add some missing NListTypes.

[Nick Kledzik]

On Jan 3, 2014, at 5:50 PM, Joey Gouly <joey.gouly at gmail.com> wrote:

> Weird, I'm sure I added it because I was hitting it in some tests, but re-running those, and it looks like I'm not.
> 
> Shall we revert this? (If I hit those again, I'll look closer)
Is there a way to mark the underlying constants deprecated or obsolete in llvm/Support/MachO.h?  I’d like to clean up the MachO.h file that way.  Then you could not accidentally use them in lld.

-Nick


> 
> 
> On 4 January 2014 01:38, Nick Kledzik <kledzik at apple.com> wrote:
> 
> On Jan 3, 2014, at 5:22 PM, Joey Gouly <joey.gouly at gmail.com> wrote:
> > Author: joey
> > Date: Fri Jan  3 19:22:05 2014
> > New Revision: 198468
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=198468&view=rev
> > Log:
> > [MachO] Add some missing NListTypes.
> >
> > Modified:
> >    lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp
> >
> > Modified: lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp
> > URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp?rev=198468&r1=198467&r2=198468&view=diff
> > ==============================================================================
> > --- lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp (original)
> > +++ lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp Fri Jan  3 19:22:05 2014
> > @@ -244,6 +244,8 @@ struct ScalarEnumerationTraits<NListType
> >     io.enumCase(value, "N_UNDF",  llvm::MachO::N_UNDF);
> >     io.enumCase(value, "N_ABS",   llvm::MachO::N_ABS);
> >     io.enumCase(value, "N_SECT",  llvm::MachO::N_SECT);
> > +    io.enumCase(value, "N_PBUD",  llvm::MachO::N_PBUD);
> N_PUBD is obsolete and has not been used for 5+ years.
> 
> 
> > +    io.enumCase(value, "N_INDR",  llvm::MachO::N_INDR);
> This too is no longer used, but I have a bug that there is a case for bringing it back.
> 
> -Nick
> 
> 
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140103/ec2378c9/attachment.html>