[PATCH] ARM: move ARMUnwindOp.h into Support
Renato Golin
renato.golin at linaro.org
Thu Jan 2 05:58:10 PST 2014
I'd wait for Tim's and Logan's reviews, but apart from my comments on "using namespace", seems reasonable to me.
cheers,
--renato
================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:50
@@ -49,2 +49,3 @@
using namespace llvm;
+using namespace ARM::EHABI;
----------------
I think this should better be explicit in each declaration, rather than importing the whole namespace.
================
Comment at: lib/Target/ARM/MCTargetDesc/ARMUnwindOpAsm.cpp:21
@@ -21,2 +20,3 @@
using namespace llvm;
+using namespace ARM::EHABI;
----------------
Same here.
http://llvm-reviews.chandlerc.com/D2494
More information about the llvm-commits
mailing list