[lld] r198266 - The return value of createInternalFiles is unused, so remove it.

[Joey Gouly]

Author: joey
Date: Tue Dec 31 13:15:42 2013
New Revision: 198266

URL: http://llvm.org/viewvc/llvm-project?rev=198266&view=rev
Log:
The return value of createInternalFiles is unused, so remove it.

Modified:
    lld/trunk/include/lld/Core/LinkingContext.h
    lld/trunk/lib/Core/LinkingContext.cpp
    lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.cpp
    lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.h
    lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.cpp
    lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.h

Modified: lld/trunk/include/lld/Core/LinkingContext.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/LinkingContext.h?rev=198266&r1=198265&r2=198266&view=diff
==============================================================================
--- lld/trunk/include/lld/Core/LinkingContext.h (original)
+++ lld/trunk/include/lld/Core/LinkingContext.h Tue Dec 31 13:15:42 2013
@@ -236,7 +236,7 @@ public:
   /// during link. Flavors can override this function in their LinkingContext
   /// to add more internal files. These internal files are positioned before
   /// the actual input files.
-  virtual bool createInternalFiles(std::vector<std::unique_ptr<File> > &) const;
+  virtual void createInternalFiles(std::vector<std::unique_ptr<File> > &) const;
 
   /// Return the list of undefined symbols that are specified in the
   /// linker command line, using the -u option.

Modified: lld/trunk/lib/Core/LinkingContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/LinkingContext.cpp?rev=198266&r1=198265&r2=198266&view=diff
==============================================================================
--- lld/trunk/lib/Core/LinkingContext.cpp (original)
+++ lld/trunk/lib/Core/LinkingContext.cpp Tue Dec 31 13:15:42 2013
@@ -71,7 +71,7 @@ LinkingContext::createUndefinedSymbolFil
   return std::move(undefinedSymFile);
 }
 
-bool LinkingContext::createInternalFiles(
+void LinkingContext::createInternalFiles(
     std::vector<std::unique_ptr<File> > &result) const {
   std::unique_ptr<File> internalFile;
   internalFile = createEntrySymbolFile();
@@ -80,7 +80,6 @@ bool LinkingContext::createInternalFiles
   internalFile = createUndefinedSymbolFile();
   if (internalFile)
     result.push_back(std::move(internalFile));
-  return true;
 }
 
 void LinkingContext::setResolverState(uint32_t state) {

Modified: lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.cpp?rev=198266&r1=198265&r2=198266&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.cpp Tue Dec 31 13:15:42 2013
@@ -90,7 +90,7 @@ private:
 };
 }
 
-bool elf::HexagonLinkingContext::createInternalFiles(
+void elf::HexagonLinkingContext::createInternalFiles(
     std::vector<std::unique_ptr<File> > &result) const {
   ELFLinkingContext::createInternalFiles(result);
   std::unique_ptr<HexagonInitFiniFile> initFiniFile(
@@ -100,5 +100,4 @@ bool elf::HexagonLinkingContext::createI
   for (auto ai:finiFunctions())
     initFiniFile->addFiniFunction(ai);
   result.push_back(std::move(initFiniFile));
-  return true;
 }

Modified: lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.h?rev=198266&r1=198265&r2=198266&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.h Tue Dec 31 13:15:42 2013
@@ -66,7 +66,7 @@ public:
   }
 
   /// \brief Create Internal files for Init/Fini
-  bool createInternalFiles(std::vector<std::unique_ptr<File> > &result) const;
+  void createInternalFiles(std::vector<std::unique_ptr<File> > &result) const;
 };
 
 } // elf

Modified: lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.cpp?rev=198266&r1=198265&r2=198266&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.cpp Tue Dec 31 13:15:42 2013
@@ -101,7 +101,7 @@ void elf::X86_64LinkingContext::addPasse
   ELFLinkingContext::addPasses(pm);
 }
 
-bool elf::X86_64LinkingContext::createInternalFiles(
+void elf::X86_64LinkingContext::createInternalFiles(
     std::vector<std::unique_ptr<File> > &result) const {
   ELFLinkingContext::createInternalFiles(result);
   std::unique_ptr<X86_64InitFiniFile> initFiniFile(
@@ -111,6 +111,5 @@ bool elf::X86_64LinkingContext::createIn
   for (auto ai:finiFunctions())
     initFiniFile->addFiniFunction(ai);
   result.push_back(std::move(initFiniFile));
-  return true;
 }
 

Modified: lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.h?rev=198266&r1=198265&r2=198266&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.h Tue Dec 31 13:15:42 2013
@@ -86,7 +86,7 @@ public:
   }
 
   /// \brief Create Internal files for Init/Fini
-  bool createInternalFiles(std::vector<std::unique_ptr<File> > &) const;
+  void createInternalFiles(std::vector<std::unique_ptr<File> > &) const;
 
 };
 } // end namespace elf