[patch] fix comment on findGCD

Maciej Piechotka uzytkownik2 at gmail.com
Tue Dec 31 05:45:51 PST 2013


On Mon, 2013-12-30 at 17:23 +0800, Mingjie Xing wrote:
> 2013/12/30 Mingjie Xing <mingjie.xing-Re5JQEeQqe8AvxtiuMwx3w at public.gmane.org>:
> > Hello,
> >
> > This patch fix the comment on findGCD:
> >
> > Is it OK?
> >
> > Best Regards,
> > Mingjie
> 
> Here's the new version:
> 
> Index: lib/Analysis/DependenceAnalysis.cpp
> ===================================================================
> --- lib/Analysis/DependenceAnalysis.cpp (revision 198188)
> +++ lib/Analysis/DependenceAnalysis.cpp (working copy)
> @@ -1275,8 +1275,8 @@
>  //
>  // Program 2.1, page 29.
>  // Computes the GCD of AM and BM.
> -// Also finds a solution to the equation ax - by = gdc(a, b).
> -// Returns true iff the gcd divides Delta.
> +// Also finds a solution to the equation ax + by = gcd(a, b).
> +// Return true if dependence disproved.
>  static
>  bool findGCD(unsigned Bits, APInt AM, APInt BM, APInt Delta,
>               APInt &G, APInt &X, APInt &Y) {
> 
> Thanks,
> Mingjie

iff[1] usually denotes "if and only if" so I'd not count it as typo.
I.e. "Return true if dependence disproved." might mean that it is
possible that it returns true in some other circumstances. On the other
hand "Return true iff dependence disproved." means that it cannot return
true in other circumstances.

My guess would be that it was entirely deliberate.

Regards

[1] http://en.wikipedia.org/wiki/Iff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131231/49d4b854/attachment.sig>


More information about the llvm-commits mailing list