[PATCH] Sanitize printf functions

Yury Gribov tetra2005 at gmail.com
Sun Dec 29 23:27:57 PST 2013


  > Until we don't have tsan tests, I suggest to disable this for tsan.

  Will making a copy of printf-1.c for TSan be enough? Or you want a test with an actual race?


================
Comment at: sanitizer_common/sanitizer_common_interceptors.inc:33
@@ -32,2 +32,3 @@
 
+#include <stddef.h>
 #include <stdarg.h>
----------------
Kostya Serebryany wrote:
> Yury Gribov wrote:
> > Kostya Serebryany wrote:
> > > Evgeniy Stepanov wrote:
> > > > No system includes (stdarg is a necessary evil).
> > > can you avoid this? 
> > Well, I need size_t for snprintf.
> please use SIZE_T and don't include any additional system headers
Agreed, my bad.


http://llvm-reviews.chandlerc.com/D2480



More information about the llvm-commits mailing list