[PATCH] ARM IAS: improve .eabi_attribute handling
Saleem Abdulrasool
compnerd at compnerd.org
Sun Dec 29 09:05:07 PST 2013
================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:350
@@ -309,1 +349,3 @@
+ virtual void emitIntTextAttribute(unsigned Attribute, unsigned IntValue,
+ StringRef StringValue = "");
virtual void emitArch(unsigned Arch);
----------------
Logan Chien wrote:
> I think we can drop the default value for "StringValue" argument.
Done
================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:8152
@@ -8151,3 +8151,3 @@
/// parseDirectiveEabiAttr
/// ::= .eabi_attribute int, int
bool ARMAsmParser::parseDirectiveEabiAttr(SMLoc L) {
----------------
Logan Chien wrote:
> It seems that the comment is out-of-date. I think the following comments should be added as well:
>
> /// ::= .eabi_attribute int, int, "str"
> /// ::= .eabi_attribute Tag_name, int
> /// ::= .eabi_attribute Tag_name, int, "str"
Ugh, I must have been asleep at the keyboard when typing. Adjusted to:
/// ::= .eabi_attribute int, int [, "str"]
/// ::= .eabi_attribute Tag_name, int [, "str"]
http://llvm-reviews.chandlerc.com/D2484
More information about the llvm-commits
mailing list