[patch] EXPORTED_SYMBOL_FILE support for cmake

[David Wiberg]

2013/12/29 Nico Weber <thakis at chromium.org>:
> On Sat, Dec 28, 2013 at 4:31 PM, Chandler Carruth <chandlerc at google.com>
> wrote:
>>
>>
>> On Sat, Dec 28, 2013 at 6:28 PM, Nico Weber <thakis at chromium.org> wrote:
>>>
>>> Since I won't have access to a windows or linux box until monday, this
>>> addresses a FIXME and blocks deadstripping for the cmake build, I'll land
>>> this for post-commit review and hope that the bots will help me sort things
>>> out. (I tested the non-darwin branches on my os x box by temporarily
>>> changing the conditionals, they seem to do what they're supposed to do.)
>>
>>
>> SGTM. Sorry for not replying sooner, I sent my only comment in
>> post-commit. I'm very confident the more interesting thing is sorting out
>> how to make this work on all the platforms which I see you're doing. Thanks!
>
>
> It looks like everything except windows is working. There were a few good
> suggestions on IRC, I'll take another look at windows in a few hours.
>
> If someone else gets around to it before me: cmake/modules/AddLLVM.cmake
> around line 40 is where the command comes from, and cmd.exe complains about:
>
> FAILED: cmd.exe /c cd /D C:\bb-win7\cmake-clang-i686-mingw32\build\tools\lto
> && "c:\Program Files (x86)\CMake 2.8\bin\cmake.exe" -E echo EXPORTS >
> symbol.def && type
> C:/bb-win7/cmake-clang-i686-mingw32/llvm-project/llvm/tools/lto/lto.exports
>>> symbol.def
> The syntax of the command is incorrect.
>
> Replacing the /s with \s apparently makes things work, so if the bot is
> still red in a few hours I'll try inserting a FILE(TO_NATIVE_PATH call.
>
> ( http://bb.pgr.jp/builders/cmake-clang-i686-mingw32 )
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>

I have tested with file(TO_NATIVE_PATH ...) and this works on Windows.
The argument seems to get quoted correct if the path contains a space
so I suggest removing the quotes after your call to {CAT}.